CodeReview

Table of Contents

Motivatation

Guidelines

  • Act as a human: be respectful and polite.
  • Differentiate between critical, important and stylistic remarks.
  • Ideally the code reviews should be conducted in small batches (200-400 LOC / < 90 min).
  • Caution: The author might be emotionally attached with his code.

Different Types

Code reviews can be conducted formally or informally. These are the different types of code review in this range:

  • Inspection: A formal process with a thorough analysis and defined input and output criteria.
  • Team review / Walkthrough: The changes are presented by the author in a meeting.
  • Peer review: Code changes are to be approved by a colleque.
  • Pair programming: Constant review by having two developers working to gether on the implementation.
  • Passaround: Code changes are distributed via email to a group of people.
  • Ad hoc review: Code review is done occasionally and unstructured.

(See Karl E. Wiegers in "Peer Reviews in Software: A Practical Guide" )

References

GitHubImpressum